andygrove commented on code in PR #1744:
URL: https://github.com/apache/datafusion-comet/pull/1744#discussion_r2096114350
##########
spark/src/main/scala/org/apache/comet/serde/QueryPlanSerde.scala:
##########
@@ -2518,6 +2518,15 @@ object QueryPlanSerde extends Logging with CometExprShim
{
return None
}
+ if (groupingExpressions.exists(expr =>
Review Comment:
Spark 3.x supports grouping by structs and arrays and we already have tests
passing for those cases. Grouping by map is new in Spark 4.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
