kosiew commented on code in PR #16108:
URL: https://github.com/apache/datafusion/pull/16108#discussion_r2097676700
##########
datafusion/datasource/src/schema_adapter.rs:
##########
@@ -248,29 +267,11 @@ impl SchemaAdapter for DefaultSchemaAdapter {
&self,
file_schema: &Schema,
) -> datafusion_common::Result<(Arc<dyn SchemaMapper>, Vec<usize>)> {
- let mut projection = Vec::with_capacity(file_schema.fields().len());
- let mut field_mappings = vec![None;
self.projected_table_schema.fields().len()];
-
- for (file_idx, file_field) in file_schema.fields.iter().enumerate() {
- if let Some((table_idx, table_field)) =
- self.projected_table_schema.fields().find(file_field.name())
- {
- match can_cast_types(file_field.data_type(),
table_field.data_type()) {
- true => {
- field_mappings[table_idx] = Some(projection.len());
- projection.push(file_idx);
- }
- false => {
- return plan_err!(
- "Cannot cast file schema field {} of type {:?} to
table schema field of type {:?}",
- file_field.name(),
- file_field.data_type(),
- table_field.data_type()
- )
- }
- }
- }
- }
+ let (field_mappings, projection) = create_field_mapping(
+ file_schema,
+ &self.projected_table_schema,
+ can_cast_field,
+ )?;
Review Comment:
refactor into a helper function so that we can re-use it later for
deep-nested SchemaAdapter
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
