kazuyukitanimura commented on code in PR #1710:
URL: https://github.com/apache/datafusion-comet/pull/1710#discussion_r2098399653
##########
native/core/src/parquet/schema_adapter.rs:
##########
@@ -226,6 +227,13 @@ impl SchemaMapper for SchemaMapping {
let record_batch = RecordBatch::try_new_with_options(schema, cols,
&options)?;
Ok(record_batch)
}
+
+ fn map_column_statistics(
+ &self,
+ _file_col_statistics: &[ColumnStatistics],
+ ) -> datafusion::common::Result<Vec<ColumnStatistics>> {
+ Ok(vec![])
Review Comment:
is this unused or just placeholder...?
##########
native/Cargo.toml:
##########
@@ -34,11 +34,11 @@ edition = "2021"
rust-version = "1.85"
[workspace.dependencies]
-arrow = { version = "55.0.0", features = ["prettyprint", "ffi", "chrono-tz"] }
+arrow = { version = "55.1.0", features = ["prettyprint", "ffi", "chrono-tz"] }
async-trait = { version = "0.1" }
bytes = { version = "1.10.0" }
parquet = { version = "55.0.0", default-features = false, features =
["experimental"] }
Review Comment:
parquet should be `55.1.0` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
