Copilot commented on code in PR #16081:
URL: https://github.com/apache/datafusion/pull/16081#discussion_r2099329043
##########
datafusion-cli/src/main.rs:
##########
@@ -169,9 +179,22 @@ async fn main_inner() -> Result<()> {
if let Some(memory_limit) = args.memory_limit {
// set memory pool type
let pool: Arc<dyn MemoryPool> = match args.mem_pool_type {
- PoolType::Fair => Arc::new(FairSpillPool::new(memory_limit)),
- PoolType::Greedy => Arc::new(GreedyMemoryPool::new(memory_limit)),
+ PoolType::Fair if args.top_memory_consumers == 0 => {
+ Arc::new(FairSpillPool::new(memory_limit))
+ }
+ PoolType::Fair => Arc::new(TrackConsumersPool::new(
+ FairSpillPool::new(memory_limit),
+ NonZeroUsize::new(args.top_memory_consumers).unwrap(),
+ )),
+ PoolType::Greedy if args.top_memory_consumers == 0 => {
+ Arc::new(GreedyMemoryPool::new(memory_limit))
+ }
+ PoolType::Greedy => Arc::new(TrackConsumersPool::new(
+ GreedyMemoryPool::new(memory_limit),
+ NonZeroUsize::new(args.top_memory_consumers).unwrap(),
+ )),
};
Review Comment:
[nitpick] The logic for wrapping Fair and Greedy pools with
TrackConsumersPool is duplicated. Consider refactoring this common
functionality into a helper function to reduce code duplication.
##########
docs/source/user-guide/cli/usage.md:
##########
@@ -57,6 +57,9 @@ OPTIONS:
--mem-pool-type <MEM_POOL_TYPE>
Specify the memory pool type 'greedy' or 'fair', default to
'greedy'
+ --top-memory-consumers <TOP_MEMORY_CONSUMERS>
Review Comment:
[nitpick] It would be helpful to document that the default value is 3,
ensuring users know that setting it to 0 disables memory consumer tracking.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
