ding-young commented on code in PR #16081:
URL: https://github.com/apache/datafusion/pull/16081#discussion_r2100740833
##########
datafusion-cli/src/main.rs:
##########
@@ -169,9 +179,22 @@ async fn main_inner() -> Result<()> {
if let Some(memory_limit) = args.memory_limit {
// set memory pool type
let pool: Arc<dyn MemoryPool> = match args.mem_pool_type {
- PoolType::Fair => Arc::new(FairSpillPool::new(memory_limit)),
- PoolType::Greedy => Arc::new(GreedyMemoryPool::new(memory_limit)),
+ PoolType::Fair if args.top_memory_consumers == 0 => {
+ Arc::new(FairSpillPool::new(memory_limit))
+ }
+ PoolType::Fair => Arc::new(TrackConsumersPool::new(
+ FairSpillPool::new(memory_limit),
+ NonZeroUsize::new(args.top_memory_consumers).unwrap(),
+ )),
+ PoolType::Greedy if args.top_memory_consumers == 0 => {
+ Arc::new(GreedyMemoryPool::new(memory_limit))
+ }
+ PoolType::Greedy => Arc::new(TrackConsumersPool::new(
+ GreedyMemoryPool::new(memory_limit),
+ NonZeroUsize::new(args.top_memory_consumers).unwrap(),
+ )),
};
Review Comment:
@2010YOUY01 I ended up keeping the match statement as is since
`TrackConsumersPool::new()` requires a concrete type implementing `MemoryPool`,
and we can't wrap a `dyn MemoryPool` directly. :cry:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
