alamb commented on code in PR #16086:
URL: https://github.com/apache/datafusion/pull/16086#discussion_r2100907909
##########
datafusion/datasource-parquet/src/opener.rs:
##########
@@ -178,7 +182,7 @@ impl FileOpener for ParquetOpener {
// Build predicates for this specific file
let (pruning_predicate, page_pruning_predicate) =
build_pruning_predicates(
predicate.as_ref(),
- &physical_file_schema,
+ &logical_file_schema,
Review Comment:
I think the key observation is that the predicates are expressed in terms of
the table schema (not the file schema).
Today there is a bunch of logic to translate table schema -> file schema
for data and statistics.
So in order to evaluate predicates on the physical schema we would need to
translate the expression as well, which I think is what @adriangb is saying
above
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
