alamb commented on code in PR #16086:
URL: https://github.com/apache/datafusion/pull/16086#discussion_r2103114864


##########
datafusion/core/src/datasource/physical_plan/parquet.rs:
##########
@@ -848,6 +864,88 @@ mod tests {
         assert_eq!(read.len(), 0);
     }
 
+    #[tokio::test]
+    async fn evolved_schema_column_type_filter_strings() {
+        // The table and filter have a common data type, but the file schema 
differs
+        let c1: ArrayRef =
+            Arc::new(StringViewArray::from(vec![Some("foo"), Some("bar")]));
+        let batch = create_batch(vec![("c1", c1.clone())]);
+
+        let schema = Arc::new(Schema::new(vec![Field::new("c1", 
DataType::Utf8, false)]));
+
+        // Predicate should prune all row groups
+        let filter = 
col("c1").eq(lit(ScalarValue::Utf8(Some("aaa".to_string()))));

Review Comment:
   Upon more reflection, I think the predicate needs to be created using the 
logical schema today
   
   @adriangb @etseidl  and myself are discussing potentially changing that here:
   - https://github.com/apache/datafusion/issues/15780



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Reply via email to