logan-keede commented on issue #5492: URL: https://github.com/apache/datafusion/issues/5492#issuecomment-2902371905
@duongcongtoai do you think we should have a feature branch for this? I think that as you work on detecting correlated queries(dependent join) you will create a logical plan that actually can't be executed because we currently do not support Dependent Join (and seems like we dont plan to, as correlated can now be completed decorrelated (if I read the paper right.)). This will necessitate you to either put decorrelation logic in the same PR or implement Dummy Dependent Join which I think will leave some existing queries broken. You will either end up with a long PR or broken queries making it difficult to review/merge. Alternatively you can try putting this code behind feature gates, though I am not sure how that would work out or if that would be easier than having feature branch. Let me know If I am wrong, or if you have other plans. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
