lifan-ake commented on code in PR #16184:
URL: https://github.com/apache/datafusion/pull/16184#discussion_r2106399160
##########
datafusion/expr/src/logical_plan/builder.rs:
##########
@@ -2269,11 +2270,11 @@ mod tests {
.project(vec![col("id")])?
.build()?;
- let expected = "Projection: employee_csv.id\
- \n Filter: employee_csv.state = Utf8(\"CO\")\
- \n TableScan: employee_csv projection=[id, state]";
-
- assert_eq!(expected, format!("{plan}"));
+ assert_snapshot!(format!("{plan}"), @r#"
Review Comment:
fixed
##########
datafusion/expr/src/logical_plan/plan.rs:
##########
@@ -4380,18 +4364,13 @@ digraph {
};
let plan = test_plan();
let res = plan.visit_with_subqueries(&mut visitor).unwrap_err();
- assert_eq!(
- "This feature is not implemented: Error in post_visit",
- res.strip_backtrace()
+ assert_snapshot!(
+ res.strip_backtrace(),
+ @"This feature is not implemented: Error in post_visit"
);
- assert_eq!(
- visitor.inner.strings,
- vec![
- "pre_visit Projection",
- "pre_visit Filter",
- "pre_visit TableScan",
- "post_visit TableScan",
- ]
+ assert_snapshot!(
+ visitor.inner.strings.join(", "),
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
