Re: [PR] migrate `logical_plan` tests to insta [datafusion]

[via GitHub]

lifan-ake commented on code in PR #16184:
URL: https://github.com/apache/datafusion/pull/16184#discussion_r2107141509


##########
datafusion/expr/src/logical_plan/builder.rs:
##########
@@ -2592,19 +2587,29 @@ mod tests {
         let err = nested_table_scan("test_table")?
             .unnest_column("scalar")
             .unwrap_err();
-        assert!(err
-            .to_string()
-            .starts_with("Internal error: trying to unnest on invalid data 
type UInt32"));
+
+        let DataFusionError::Internal(desc) = err else {
+            return plan_err!("Plan should have returned an 
DataFusionError::Internal");
+        };
+
+        let desc = desc
+            .split(DataFusionError::BACK_TRACE_SEP)
+            .collect::<Vec<&str>>()
+            .first()
+            .unwrap_or(&"")
+            .to_string();
+
+        assert_snapshot!(desc, @"trying to unnest on invalid data type 
UInt32");

Review Comment:
   
![image](https://github.com/user-attachments/assets/12c01d39-09f4-4c10-bde1-61c0ea8f75d2)
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org