andygrove commented on code in PR #1815:
URL: https://github.com/apache/datafusion-comet/pull/1815#discussion_r2114468324
##########
common/src/main/java/org/apache/comet/parquet/NativeBatchReader.java:
##########
@@ -236,7 +236,7 @@ public NativeBatchReader(AbstractColumnReader[]
columnReaders) {
public void init() throws Throwable {
conf.set("spark.sql.parquet.binaryAsString", "false");
- conf.set("spark.sql.parquet.int96AsTimestamp", "false");
+ conf.set("spark.sql.parquet.int96AsTimestamp", "true");
Review Comment:
I still have questions about these configs. In the unikely event that a user
explicity sets `spark.sql.parquet.int96AsTimestamp=false`, shouldn't we respect
that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
