zhuqi-lucas commented on PR #16196: URL: https://github.com/apache/datafusion/pull/16196#issuecomment-2943654190
> @zhuqi-lucas regarding corner cases, I've added two additional tests on my branch for filter and join. > > Filter can refuse to cancel if the filter rejects many full batches. I've added a test case that filters out everything to emulate this. > > Joins can block in their build phase. I've emulated this situation using the infinite source that pretends to be bounded rather than unbounded. > > In both cases the emission type is not final for these plans. > Left an initial round of reviews, let's address them and do another round Thank you @ozankabak for review and great suggestions, i will try to address soon. > @zhuqi-lucas regarding corner cases, I've added two additional tests on my branch for filter and join. > > Filter can refuse to cancel if the filter rejects many full batches. I've added a test case that filters out everything to emulate this. > > Joins can block in their build phase. I've emulated this situation using the infinite source that pretends to be bounded rather than unbounded. > > In both cases the emission type is not final for these plans. Thank you @pepijnve , let me try to learn and add the complex testing cases, it's really helpful. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
