zhuqi-lucas commented on code in PR #16196:
URL: https://github.com/apache/datafusion/pull/16196#discussion_r2128830214
##########
datafusion/physical-plan/src/execution_plan.rs:
##########
@@ -546,6 +558,23 @@ pub trait ExecutionPlan: Debug + DisplayAs + Send + Sync {
child_pushdown_result,
))
}
+
+ /// Whether this operator supports cooperative yielding. Default is false.
+ fn yields_cooperatively(&self) -> bool {
+ false
Review Comment:
Thank you @ozankabak for this good point.
But i tried to add emission_type related behaviour, but actually currently,
we only use emission_type final to choose the leaf nodes to add the yield
stream.
So this return false, it's the clear and easy way until now. If we change
our design later, such as we add the yield behaviour not for leaves, but before
the emission_type final node, we may can change this to related emission_type,
but it's also not a easy way, because we need to insert to before emission_type
final node not after the emission_type final node.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
