iffyio commented on code in PR #1865:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1865#discussion_r2131627748
##########
tests/sqlparser_common.rs:
##########
@@ -9132,7 +9132,9 @@ fn test_create_index_with_with_clause() {
#[test]
fn parse_drop_index() {
let sql = "DROP INDEX idx_a";
- match verified_stmt(sql) {
+ // MySql dialect doesn't support `DROP INDEX idx_a`,you need to specify a
specific table, please refer:
+ // [MySql](https://dev.mysql.com/doc/refman/8.4/en/drop-index.html)
+ match all_dialects_except(|d| d.is::<MySqlDialect>()).verified_stmt(sql) {
Review Comment:
not sure I followed the intent here, from the code in this PR the parser
doesnt seem to have started rejecting any `DROP INDEX` statement variants
specifically for mysql, so that I imagined these should still have been passing
for mysql?
##########
src/ast/ddl.rs:
##########
@@ -187,6 +187,14 @@ pub enum AlterTableOperation {
DropForeignKey {
name: Ident,
},
+ /// `DROP INDEX <index_name>`
+ ///
+ /// Note: this is a [MySQL]-specific operation.
+ ///
Review Comment:
```suggestion
```
I think we can skip the note, since we're already linking to the mysql docs
below
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
