parthchandra commented on code in PR #1830:
URL: https://github.com/apache/datafusion-comet/pull/1830#discussion_r2133051606
##########
common/src/main/java/org/apache/comet/parquet/TypeUtil.java:
##########
@@ -74,7 +74,8 @@ public static ColumnDescriptor convertToParquet(StructField
field) {
builder = Types.primitive(PrimitiveType.PrimitiveTypeName.INT64,
repetition);
} else if (type == DataTypes.BinaryType) {
builder = Types.primitive(PrimitiveType.PrimitiveTypeName.BINARY,
repetition);
- } else if (type == DataTypes.StringType) {
+ } else if (type == DataTypes.StringType
+ || (type.sameType(DataTypes.StringType) && isSpark40Plus())) {
Review Comment:
Isn't it sufficient to call `type.sameType` for any version of Spark?
##########
spark/src/main/scala/org/apache/comet/serde/QueryPlanSerde.scala:
##########
@@ -1437,7 +1437,7 @@ object QueryPlanSerde extends Logging with CometExprShim {
case s: StringDecode =>
// Right child is the encoding expression.
- s.right match {
+ s.charset match {
Review Comment:
nit: Is there a subtle difference in Spark 4? `s.bin` and `s.charset` are
simply aliases for `s.left` and `s.right`
(I admit this looks more useful)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
