huaxingao commented on code in PR #1830:
URL: https://github.com/apache/datafusion-comet/pull/1830#discussion_r2135066516
##########
spark/src/main/scala/org/apache/comet/serde/QueryPlanSerde.scala:
##########
@@ -1437,7 +1437,7 @@ object QueryPlanSerde extends Logging with CometExprShim {
case s: StringDecode =>
// Right child is the encoding expression.
- s.right match {
+ s.charset match {
Review Comment:
```
override def left: Expression = bin
override def right: Expression = charset
```
The above was removed in 4.0. That's why we can't use s.left and s.right any
more.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
