xudong963 commented on code in PR #16290:
URL: https://github.com/apache/datafusion/pull/16290#discussion_r2139606271
##########
datafusion/common/src/config.rs:
##########
@@ -264,6 +264,11 @@ config_namespace! {
/// Default is false.
pub map_varchar_to_utf8view: bool, default = true
+ /// If true, `CHAR` and `Text` and `String` is mapped to `Utf8View`
during SQL planning.
+ /// If false, `CHAR` and `Text` and `String` is mapped to `Utf8`
during SQL planning.
+ /// Default is true.
+ pub map_char_to_utf8view: bool, default = true
+
Review Comment:
Do we need the two configs? I mean, if we can directly use one.
Imagine that one is true, and another is false, does it make sense? Before
we didn't have `utf8view`, varchar,char, text, string all will be utf8, they're
consistent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
