andygrove commented on code in PR #1864:
URL: https://github.com/apache/datafusion-comet/pull/1864#discussion_r2143694940
##########
spark/src/main/scala/org/apache/comet/serde/QueryPlanSerde.scala:
##########
@@ -952,32 +947,23 @@ object QueryPlanSerde extends Logging with CometExprShim {
binding,
(builder, binaryExpr) => builder.setRlike(binaryExpr))
- case StartsWith(left, right) =>
- createBinaryExpr(
- expr,
- left,
- right,
- inputs,
- binding,
- (builder, binaryExpr) => builder.setStartsWith(binaryExpr))
-
- case EndsWith(left, right) =>
- createBinaryExpr(
- expr,
- left,
- right,
- inputs,
- binding,
- (builder, binaryExpr) => builder.setEndsWith(binaryExpr))
-
- case Contains(left, right) =>
- createBinaryExpr(
- expr,
- left,
- right,
- inputs,
- binding,
- (builder, binaryExpr) => builder.setContains(binaryExpr))
+ case _: StartsWith =>
+ val startsWithExpr = expr.asInstanceOf[StartsWith]
Review Comment:
The `asInstanceOf` cast can be avoided here:
```suggestion
case startsWithExpr: StartsWith =>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
