hendrikmakait commented on code in PR #16497:
URL: https://github.com/apache/datafusion/pull/16497#discussion_r2159905884


##########
datafusion/physical-plan/src/metrics/baseline.rs:
##########
@@ -58,6 +58,7 @@ pub struct BaselineMetrics {
 impl BaselineMetrics {
     /// Create a new BaselineMetric structure, and set `start_time` to now
     pub fn new(metrics: &ExecutionPlanMetricsSet, partition: usize) -> Self {
+        // TODO: Is start_time used anywhere?

Review Comment:
   Drive-by: Is `start_time` actually made use of? Otherwise, I suggest 
dropping it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Reply via email to