hendrikmakait commented on code in PR #16497:
URL: https://github.com/apache/datafusion/pull/16497#discussion_r2160121396
##########
datafusion/physical-plan/src/metrics/baseline.rs:
##########
@@ -58,6 +58,7 @@ pub struct BaselineMetrics {
impl BaselineMetrics {
/// Create a new BaselineMetric structure, and set `start_time` to now
pub fn new(metrics: &ExecutionPlanMetricsSet, partition: usize) -> Self {
+ // TODO: Is start_time used anywhere?
Review Comment:
This piece of code does set the value for `start_time`. It is accessible via
the `ExecutionPlanMetricsSet`. It still feels odd though that it is excluded
from the `BaselineMetrics`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
