alamb commented on PR #16506: URL: https://github.com/apache/datafusion/pull/16506#issuecomment-2999628483
🤔 the benchmarks seem to imply this has some non trivial overhead (slows down planning by 1-2%). I wonder if there is any way to restructure the affected codepaths to avoid the recursion (change them into an iterative version, for example, or `Box` more structures to reduce the stack size?) Also, while I appreciate you can't provide the exact reproducer, I think it is important that we have some tests for this change, otherwise it is likely that over time as the code is refactored we'll either lose the annotations or the paths will be different and not annotated -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
