alamb commented on code in PR #16424:
URL: https://github.com/apache/datafusion/pull/16424#discussion_r2164757786
##########
datafusion/datasource-parquet/src/opener.rs:
##########
@@ -524,6 +512,91 @@ fn should_enable_page_index(
.unwrap_or(false)
}
+/// Prune based on partition values and file-level statistics.
+pub struct FilePruner {
Review Comment:
- filed https://github.com/apache/datafusion/issues/16542
##########
datafusion/physical-expr-common/src/physical_expr.rs:
##########
@@ -345,6 +347,24 @@ pub trait PhysicalExpr: Send + Sync + Display + Debug +
DynEq + DynHash {
// This is a safe default behavior.
Ok(None)
}
+
+ /// Returns the generation of this `PhysicalExpr` for snapshotting
purposes.
Review Comment:
I like this design.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
