leung-ming commented on PR #1893:
URL: 
https://github.com/apache/datafusion-comet/pull/1893#issuecomment-3015975515

   performance looks improved on my laptop (i7-10710U)
   before:
   ```
   aggregate/avg_decimal_datafusion
                           time:   [1.5631 ms 1.5829 ms 1.6037 ms]
                           change: [-0.9603% +0.6880% +2.3740%] (p = 0.44 > 
0.05)
                           No change in performance detected.
   aggregate/avg_decimal_comet
                           time:   [1.8959 ms 1.9169 ms 1.9391 ms]
                           change: [-0.8956% +0.6495% +2.0594%] (p = 0.41 > 
0.05)
                           No change in performance detected.
   ```
   after:
   ```
   aggregate/avg_decimal_datafusion
                           time:   [1.5650 ms 1.5799 ms 1.5954 ms]
                           change: [-3.7753% -2.2319% -0.6501%] (p = 0.01 < 
0.05)
                           Change within noise threshold.
   aggregate/avg_decimal_comet
                           time:   [1.5122 ms 1.5303 ms 1.5505 ms]
                           change: [-1.8545% -0.3045% +1.5685%] (p = 0.72 > 
0.05)
                           No change in performance detected.
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Reply via email to