comphead commented on code in PR #16580:
URL: https://github.com/apache/datafusion/pull/16580#discussion_r2173900618
##########
datafusion/sqllogictest/test_files/spark/string/luhn_check.slt:
##########
@@ -23,16 +23,34 @@
## Original Query: SELECT luhn_check('79927398713');
## PySpark 3.5.5 Result: {'luhn_check(79927398713)': True,
'typeof(luhn_check(79927398713))': 'boolean', 'typeof(79927398713)': 'string'}
-#query
-#SELECT luhn_check('79927398713'::string);
+query B
+SELECT luhn_check('79927398713'::string);
+----
+true
## Original Query: SELECT luhn_check('79927398714');
## PySpark 3.5.5 Result: {'luhn_check(79927398714)': False,
'typeof(luhn_check(79927398714))': 'boolean', 'typeof(79927398714)': 'string'}
-#query
-#SELECT luhn_check('79927398714'::string);
+query B
+SELECT luhn_check('79927398714'::string);
+----
+false
## Original Query: SELECT luhn_check('8112189876');
## PySpark 3.5.5 Result: {'luhn_check(8112189876)': True,
'typeof(luhn_check(8112189876))': 'boolean', 'typeof(8112189876)': 'string'}
-#query
-#SELECT luhn_check('8112189876'::string);
+query B
+SELECT luhn_check('8112189876'::string);
+----
+true
+query B
Review Comment:
can we also add test with extra large numbers, not valid numbers, fractional
and negative?
##########
datafusion/sqllogictest/test_files/spark/string/luhn_check.slt:
##########
@@ -23,16 +23,34 @@
## Original Query: SELECT luhn_check('79927398713');
## PySpark 3.5.5 Result: {'luhn_check(79927398713)': True,
'typeof(luhn_check(79927398713))': 'boolean', 'typeof(79927398713)': 'string'}
-#query
-#SELECT luhn_check('79927398713'::string);
+query B
+SELECT luhn_check('79927398713'::string);
+----
+true
## Original Query: SELECT luhn_check('79927398714');
## PySpark 3.5.5 Result: {'luhn_check(79927398714)': False,
'typeof(luhn_check(79927398714))': 'boolean', 'typeof(79927398714)': 'string'}
-#query
-#SELECT luhn_check('79927398714'::string);
+query B
+SELECT luhn_check('79927398714'::string);
+----
+false
## Original Query: SELECT luhn_check('8112189876');
## PySpark 3.5.5 Result: {'luhn_check(8112189876)': True,
'typeof(luhn_check(8112189876))': 'boolean', 'typeof(8112189876)': 'string'}
-#query
-#SELECT luhn_check('8112189876'::string);
+query B
+SELECT luhn_check('8112189876'::string);
+----
+true
+query B
Review Comment:
can we also add test with extra large numbers, not valid numbers,
fractional, exponential and negative?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
