comphead commented on code in PR #16803:
URL: https://github.com/apache/datafusion/pull/16803#discussion_r2213640997
##########
datafusion/core/src/datasource/listing/table.rs:
##########
@@ -101,7 +101,7 @@ pub struct ListingTableConfig {
/// Optional [`SchemaAdapterFactory`] for creating schema adapters
schema_adapter_factory: Option<Arc<dyn SchemaAdapterFactory>>,
/// Optional [`PhysicalExprAdapterFactory`] for creating physical
expression adapters
- physical_expr_adapter_factory: Option<Arc<dyn PhysicalExprAdapterFactory>>,
+ expr_adapter_factory: Option<Arc<dyn PhysicalExprAdapterFactory>>,
Review Comment:
this rename might cause `api_change` label along with `Upgrade Guide`
changes, I would stick to just example in this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
