huaxingao commented on code in PR #2032:
URL: https://github.com/apache/datafusion-comet/pull/2032#discussion_r2217013989
##########
common/src/main/java/org/apache/comet/parquet/BatchReader.java:
##########
@@ -183,9 +183,7 @@ public BatchReader(
this.taskContext = TaskContext$.MODULE$.get();
}
- public BatchReader(AbstractColumnReader[] columnReaders) {
- // Todo: set useDecimal128 and useLazyMaterialization
- int numColumns = columnReaders.length;
+ public BatchReader(int numColumns) {
Review Comment:
@parthchandra Thanks for taking a look at this PR!
The column readers are created
[here](https://github.com/apache/iceberg/blob/main/spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/data/vectorized/CometVectorizedReaderBuilder.java#L66)
and passed to Batch Reader at
[here](https://github.com/apache/iceberg/blob/main/spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/data/vectorized/VectorizedSparkParquetReaders.java#L86)
`isInitialized` is still true.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
