parthchandra commented on code in PR #2032:
URL: https://github.com/apache/datafusion-comet/pull/2032#discussion_r2220495577
##########
common/src/main/java/org/apache/comet/parquet/BatchReader.java:
##########
@@ -183,9 +183,7 @@ public BatchReader(
this.taskContext = TaskContext$.MODULE$.get();
}
- public BatchReader(AbstractColumnReader[] columnReaders) {
- // Todo: set useDecimal128 and useLazyMaterialization
- int numColumns = columnReaders.length;
+ public BatchReader(int numColumns) {
Review Comment:
Thanks @huaxingao for pointing out that the column readers are being set
here -
https://github.com/apache/iceberg/blob/main/spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/data/vectorized/CometColumnarBatchReader.java#L90
I would recommend an `init` API that takes the column readers as parameter
and sets the initialization flag to true.
Essentially, there will be an `init` method for this variant of the
constructor to mirror the `init` method used by with Spark
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
