ding-young commented on code in PR #15700:
URL: https://github.com/apache/datafusion/pull/15700#discussion_r2218214013
##########
datafusion/physical-plan/src/spill/spill_manager.rs:
##########
@@ -125,6 +133,156 @@ impl SpillManager {
self.spill_record_batch_and_finish(&batches, request_description)
}
+ /// Refer to the documentation for
[`Self::spill_record_batch_and_finish`]. This method
+ /// additionally spills the `RecordBatch` into smaller batches, divided by
`row_limit`.
+ ///
+ /// # Errors
+ /// - Returns an error if spilling would exceed the disk usage limit
configured
+ /// by `max_temp_directory_size` in `DiskManager`
+ pub(crate) fn spill_record_batch_by_size_and_return_max_batch_memory(
+ &self,
+ batch: &RecordBatch,
+ request_description: &str,
Review Comment:
Nit: Maybe it might be better to unify the naming. Some functions use
`request_msg`, others use `request_description`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
