aharpervc commented on code in PR #1949:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1949#discussion_r2220366992
##########
src/parser/mod.rs:
##########
@@ -266,6 +266,22 @@ impl ParserOptions {
self.unescape = unescape;
self
}
+
+ /// Set if semicolon statement delimiters are required.
Review Comment:
> What is the usecase to have the same configuration information on the
ParserOptions and the Dialect?
It's similar to the existing `with_trailing_commas` logic, and has several
practical use cases:
1. can be set to `true` for SQL Server & left `false` for all others (until
if/when someone discovers this is supported in other dialects)
2. integration with existing testing patterns. eg, we can have
`all_dialects_requiring_semicolon_statement_delimiter` &
`all_dialects_not_requiring_semicolon_statement_delimiter`
3. used to set the corresponding default parser option
It seems like testing parsing without semicolons would get a lot worse if it
_wasn't_ a dialect option
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
