LiaCastaneda commented on code in PR #16858:
URL: https://github.com/apache/datafusion/pull/16858#discussion_r2224790385
##########
datafusion/proto/src/physical_plan/from_proto.rs:
##########
@@ -368,7 +368,12 @@ pub fn parse_physical_expr(
e.name.as_str(),
scalar_fun_def,
args,
- Field::new("f", convert_required!(e.return_type)?,
true).into(),
+ Field::new(
+ &e.return_field_name,
+ convert_required!(e.return_type)?,
+ true,
Review Comment:
I wonder if this field could ever be non nullable, for example for udfs
defined by DF users, then the deserialization would result in a mismatch (not
in the scope of this fixes though)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
