berkaysynnada commented on PR #16918:
URL: https://github.com/apache/datafusion/pull/16918#issuecomment-3121734839

   > Comet sends sometimes a state null, true whereas DF never does that and 
send s nulls, false instead. Probably it is explained that Comet calls physical 
operations directly, without optimizations
   
   I couldn't understand this, can you explain a bit more?
   
   ```rust
   fn state(&mut self) -> Result<Vec<ScalarValue>> {
       let is_set = if self.ignore_nulls && self.first.is_null() {
           false 
       } else {
           self.is_set
       };
       Ok(vec![self.first.clone(), ScalarValue::from(is_set)])
   }
   ```
   does it mean converting `fn state()`'s such would fix the problem?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Reply via email to