berkaysynnada commented on PR #16918:
URL: https://github.com/apache/datafusion/pull/16918#issuecomment-3126923002
@comphead thanks for the detailed explanation. The `state()`'s are taken
from Comet, right? and Comet doesn't actually use my proposed change
```rust
fn state(&mut self) -> Result<Vec<ScalarValue>> {
if self.ignore_nulls && self.last.is_null() {
self.is_set = false;
};
Ok(vec![self.last.clone(), ScalarValue::from(self.is_set)])
}
```
?
If that’s the case, the problem seems to originate in Comet, because we
shouldn’t be receiving:
``` &states = [
PrimitiveArray<Int32>
[
null,
],
BooleanArray
[
true,
],
]
```
that’s an invalid state, and we shouldn’t be trying to fix it here IMO
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
