kosiew opened a new pull request, #16947: URL: https://github.com/apache/datafusion/pull/16947
## Which issue does this PR close? * Closes #16805 ## Rationale for this change This change prevents internal error types from the `object_store` crate from leaking into DataFusion's public API surface. Doing so: * Removes the requirement for downstream users to depend directly on `object_store` just to handle errors. * Decouples `DataFusionError` from specific versions of `object_store`, minimizing the risk of semver-breaking changes due to internal dependency upgrades. ## What changes are included in this PR? * Introduced a new wrapper error type `DfObjectStoreError` to encapsulate `object_store::Error` with optional context. * Replaced all usages of `DataFusionError::ObjectStore(Box<object_store::Error>)` with `DataFusionError::ObjectStore(Box<DfObjectStoreError>)`. * Updated conversions and match patterns accordingly. * Applied necessary patches across the CLI, CSV, and URL handling modules to reflect this new abstraction. ## Are these changes tested? Yes. The changes preserve the original behavior and error propagation paths. Existing tests covering `DataFusionError` handling remain valid and ensure correctness. No test regressions were introduced. ## Are there any user-facing changes? Yes, but they are backward-compatible at the API level unless users were matching directly on `object_store::Error` or using it explicitly, in which case adjustments may be needed. * Users no longer need to import or depend on the `object_store` crate to handle `DataFusionError`. * The error formatting and messages remain the same, ensuring no disruption in logs or user feedback. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
