crepererum commented on PR #16947: URL: https://github.com/apache/datafusion/pull/16947#issuecomment-3131816841
I think the question here is what the purpose of this shadowing/hiding is: I think it's OK if `object_store` is a purely internal library that the API user never interacts with. However `object_store` appears in so many public interfaces that it seems a bit pointless. Also since `object_store::Error` implements `std::error::Error` you CAN totally use the leaked type for many useful things, even without naming/importing it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
