lorenarosati opened a new issue, #16949: URL: https://github.com/apache/datafusion/issues/16949
### Describe the bug There are some Substrait functions that have implementations in DataFusion, but are not mapped to those functions in DataFusion correctly because their names are slightly different. For example, DataFusion does not understand the Substrait is_nan function, because DataFusion's name for the same function is isnan, and the Substrait consumer and producer work off of direct name mappings. ### To Reproduce On the consumer side: 1. Build a Substrait plan with one of those functions (e.g. sign). 2. Call from_substrait_plan() with the plan, and notice that it will return an unsupported function error. [sample_substrait_plan.json](https://github.com/user-attachments/files/21471920/sample_substrait_plan.json) On the producer side: 1. Create a DataFusion plan with ISNAN (e.g. the process followed by [this test](https://github.com/apache/datafusion/blob/2a7f64a85e3d98c51c106607a425d73d2b839e82/datafusion/substrait/tests/cases/roundtrip_logical_plan.rs#L415) - go from SQL to a DataFusion plan, and then convert that to a Substrait plan) 2. Call to_substrait_plan() and notice that it will return a Substrait plan with the function name isnan, which is not a function in Substrait. ### Expected behavior The consumer should build a plan with the appropriate DataFusion function name, and the producer should produce a Substrait plan with the appropriate Substrait function name. ### Additional context _No response_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
