coderfender commented on code in PR #1996:
URL: https://github.com/apache/datafusion-comet/pull/1996#discussion_r2245849616
##########
spark/src/main/scala/org/apache/comet/serde/arithmetic.scala:
##########
@@ -212,17 +211,26 @@ object CometIntegralDivide extends CometExpressionSerde
with MathBase {
return None
}
- val dataType = (div.left.dataType, div.right.dataType) match {
+ val left =
+ if (div.left.dataType.isInstanceOf[DecimalType]) div.left
+ else Cast(div.left, DecimalType(19, 0))
Review Comment:
Thank you for the review. My goal was to support a precision value of long
data type which has a precision of 19 and is the highest among all the data
types in Spark (except decimal).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
