mbutrovich commented on code in PR #2028:
URL: https://github.com/apache/datafusion-comet/pull/2028#discussion_r2246170321
##########
spark/src/main/scala/org/apache/comet/serde/QueryPlanSerde.scala:
##########
@@ -1457,9 +1406,6 @@ object QueryPlanSerde extends Logging with CometExprShim {
binding,
(builder, binaryExpr) => builder.setBitwiseAnd(binaryExpr))
- case In(value, list) =>
- in(expr, value, list, inputs, binding, negate = false)
Review Comment:
I understand now why you brought that `in` function over to
comparisons.scala. It was used here, and in `InSet` and `Not(In)`.
I think we should handle those two expressions in this PR, and bring `in`
over to comparisons.scala so the logic isn't duplicated in two places.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
