chenkovsky commented on code in PR #1970:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1970#discussion_r2249219058
##########
src/parser/mod.rs:
##########
@@ -13828,7 +13840,13 @@ impl<'a> Parser<'a> {
self.expect_token(&Token::LParen)?;
let aggregate_functions =
self.parse_comma_separated(Self::parse_aliased_function_call)?;
self.expect_keyword_is(Keyword::FOR)?;
- let value_column = self.parse_period_separated(|p|
p.parse_identifier())?;
+ let value_column = if self.peek_token_ref().token == Token::LParen {
+ self.parse_parenthesized_compound_identifier_list(Mandatory,
false)?
+ } else {
+ vec![Expr::CompoundIdentifier(
+ self.parse_period_separated(|p| p.parse_identifier())?,
+ )]
+ };
Review Comment:
no, we cannot do it here. `(name, age) IN (('John', 30) AS c1, ('Mike', 40)
AS c2)` will be parsed as an expr.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
