alamb commented on PR #16970: URL: https://github.com/apache/datafusion/pull/16970#issuecomment-3151538406
> > Not so good: DF can end up with bloating code serving the purpose of each downstream project. > > Apparently reviewers need to verify this mechanism is used properly > > Indeed. Beyond runtime switching of behaviour for custom UDF's I foresee two main use cases for the core udf's - timezone and spark-like 'ansi' mode. While I agree that this PR makes it easier to add more functionality (and thus bloat) to the core functions, I don't think it fundamentally changes the need for reviewers to help make that tradeoff when evaluating new features for inclusion -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
