alamb commented on code in PR #16970:
URL: https://github.com/apache/datafusion/pull/16970#discussion_r2252149389
##########
datafusion/ffi/src/udf/mod.rs:
##########
@@ -378,6 +381,8 @@ impl ScalarUDFImpl for ForeignScalarUDF {
arg_fields,
number_rows,
return_field,
+ // todo - should the config options go through serdes?
Review Comment:
```suggestion
// TODO: pass config options:
https://github.com/apache/datafusion/issues/17035
```
##########
datafusion/ffi/src/udf/mod.rs:
##########
@@ -207,6 +208,8 @@ unsafe extern "C" fn invoke_with_args_fn_wrapper(
arg_fields,
number_rows,
return_field,
+ // todo - should the config options go through serdes?
Review Comment:
I filed a ticket to track this:
- https://github.com/apache/datafusion/issues/17035
```suggestion
// TODO: pass config options:
https://github.com/apache/datafusion/issues/17035
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
