findepi commented on issue #17011:
URL: https://github.com/apache/datafusion/issues/17011#issuecomment-3151945598
> Thanks for the feedback. Since the `string_agg` + `ORDER BY` works with
version `48.0.0` and below, I believe it could also fall under the "fix
regressions" category.
i didn't know it did. Then it's a correctness regression warranting a
backport release.
I confirmed the following SQL returns correct results in 48.0.0 and
incorrect result in 49.0.0 (lack of sorting)
```sql
create table t (k varchar, v int);
insert into t values ('a', 2), ('b', 3), ('c', 1);
select string_agg(k, ',' order by v) from t;
```
i got biased by the "It does work after
https://github.com/apache/datafusion/commit/e1a5cdf6db791ea50b4028d6eb11ffafd940b29b";
mention, which was supposed to be a new feature work, not a regression fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
