andygrove commented on PR #2068: URL: https://github.com/apache/datafusion-comet/pull/2068#issuecomment-3161822766
> I like the refactoring but I'm not sold on the tests. I'm not sure it would prevent the issue mentioned as justification #1260. Someone who forgets to serialize a field would likely write a corresponding unit test that wouldn't look for that field, and it would quietly pass (incorrectly). I'm afraid these tests wouldn't catch the behavior we're trying to avoid, and may prove a barrier to entry for new contributors. Thanks for the feedback. Those are valid points. I have removed the new test suite. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
