alamb commented on code in PR #17081:
URL: https://github.com/apache/datafusion/pull/17081#discussion_r2263320258
##########
datafusion/expr/src/udwf.rs:
##########
@@ -305,10 +305,7 @@ where
/// .build()
/// .unwrap();
/// ```
-pub trait WindowUDFImpl: Debug + Send + Sync {
- // Note: When adding any methods (with default implementations), remember
to add them also
- // into the AliasedWindowUDFImpl below!
-
+pub trait WindowUDFImpl: Debug + DynEq + DynHash + Send + Sync {
Review Comment:
This is an API change, right? I think we should add a comment in the
Upgrading guide about this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
