kosiew commented on code in PR #17081:
URL: https://github.com/apache/datafusion/pull/17081#discussion_r2266911805
##########
datafusion/expr/src/udwf.rs:
##########
@@ -82,15 +82,15 @@ impl Display for WindowUDF {
impl PartialEq for WindowUDF {
fn eq(&self, other: &Self) -> bool {
- self.inner.equals(other.inner.as_ref())
+ self.inner.dyn_eq(&other.inner)
}
Review Comment:
should this be
```rust
self.inner.as_ref().dyn_eq(other.inner.as_ref().as_any())
```
to ensure the implementor’s dyn_eq sees &dyn Any of the concrete type (F),
making the downcast succeed when appropriate?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
