comphead commented on code in PR #17115:
URL: https://github.com/apache/datafusion/pull/17115#discussion_r2267406809
##########
datafusion/physical-plan/src/sorts/merge.rs:
##########
@@ -49,7 +49,8 @@ pub(crate) struct SortPreservingMergeStream<C: CursorValues> {
/// used to record execution metrics
metrics: BaselineMetrics,
- /// If the stream has encountered an error
+ /// If the stream has encountered an error or reaches the
Review Comment:
perhaps we can call it `completed`, `exhausted`.
`done` imho is less misleading, but still somewhat confusing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
