alamb commented on code in PR #17115:
URL: https://github.com/apache/datafusion/pull/17115#discussion_r2270694158
##########
datafusion/physical-plan/src/sorts/merge.rs:
##########
@@ -49,7 +49,8 @@ pub(crate) struct SortPreservingMergeStream<C: CursorValues> {
/// used to record execution metrics
metrics: BaselineMetrics,
- /// If the stream has encountered an error
+ /// If the stream has encountered an error or reaches the
Review Comment:
🤔
It seems like DataFusion already uses several different conventions (none of
them are `completed` or `exhausted`)
- `input_done`:
https://github.com/apache/datafusion/blob/5421825b62a4bbb977cb91ac45152b3a14ef3e88/datafusion/physical-plan/src/aggregates/row_hash.rs#L388-L387
- `done`:
https://github.com/apache/datafusion/blob/0f83c1d233499e80fd9b0baf89dd624099c1d1ba/datafusion/core/tests/user_defined/user_defined_plan.rs#L763-L762
- `finished` (in 4 places):
https://github.com/apache/datafusion/blob/9278233e9fe34f7712370f2fa583ba94663a0678/datafusion/physical-plan/src/aggregates/no_grouping.rs#L64-L63
Perhaps we can improve the name and maybe make them more consistent as a
follow on PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
