BlakeOrth commented on code in PR #17050:
URL: https://github.com/apache/datafusion/pull/17050#discussion_r2267466311
##########
datafusion/core/src/datasource/listing_table_factory.rs:
##########
@@ -375,4 +384,86 @@ mod tests {
Pattern::new("*.csv").unwrap()
);
}
+
+ #[tokio::test]
+ async fn test_create_with_hive_partitions() {
+ let dir = tempfile::tempdir().unwrap();
+ let mut path = PathBuf::from(dir.path());
+ path.extend(["key1=value1", "key2=value2"]);
+ fs::create_dir_all(&path).unwrap();
+ path.push("data.parquet");
+ fs::File::create_new(&path).unwrap();
+
+ let factory = ListingTableFactory::new();
+ let context = SessionContext::new();
+ let state = context.state();
+ let name = TableReference::bare("foo");
+
+ let cmd = CreateExternalTable {
+ name,
+ location: dir.path().to_str().unwrap().to_string(),
+ file_type: "parquet".to_string(),
+ schema: Arc::new(DFSchema::empty()),
+ table_partition_cols: vec![],
+ if_not_exists: false,
+ temporary: false,
+ definition: None,
+ order_exprs: vec![],
+ unbounded: false,
+ options: HashMap::new(),
+ constraints: Constraints::default(),
+ column_defaults: HashMap::new(),
+ };
+ let table_provider = factory.create(&state, &cmd).await.unwrap();
+ let listing_table = table_provider
+ .as_any()
+ .downcast_ref::<ListingTable>()
+ .unwrap();
+
+ let listing_options = listing_table.options();
+ let dtype =
+ DataType::Dictionary(Box::new(DataType::UInt16),
Box::new(DataType::Utf8));
+ let expected_cols = vec![
+ (String::from("key1"), dtype.clone()),
+ (String::from("key2"), dtype.clone()),
+ ];
+ assert_eq!(expected_cols, listing_options.table_partition_cols);
+ }
+
+ #[tokio::test]
+ async fn test_odd_directory_names() {
Review Comment:
Hmm, thanks for checking this. Maybe my test success criteria are off here
or something, because the code without this PR was failing to list any files
because it was using `.0` as the search extension from `/2025-07-23.0/`. I will
revisit and update this test based on what I find.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
