BlakeOrth commented on code in PR #17050:
URL: https://github.com/apache/datafusion/pull/17050#discussion_r2277674825


##########
datafusion/core/src/datasource/listing/table.rs:
##########
@@ -802,6 +802,7 @@ impl ListingOptions {
                     .rev()
                     .skip(1) // get parents only; skip the file itself
                     .rev()
+                    .filter(|s| s.contains('='))

Review Comment:
   Ah, yes, the dataset I was trying to use which exposed the initial issue 
(failure to infer partition columns) is, as you've noted, properly formed in 
terms of hive partitioning. This specific fix of filtering out non-conformant 
directories was actually necessary to keep an existing .slt test from failing 
once partition inference was introduced.
   
   (I'm currently building/running the tests without this portion of the PR to 
get the specific failure and will note it here once the test run is complete)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Reply via email to