shruti2522 commented on code in PR #17100:
URL: https://github.com/apache/datafusion/pull/17100#discussion_r2267283248
##########
datafusion/core/tests/fuzz_cases/aggregate_fuzz.rs:
##########
@@ -320,7 +320,7 @@ async fn run_aggregate_test(input1: Vec<RecordBatch>,
group_by_columns: Vec<&str
.unwrap();
let running_source = DataSourceExec::from_data_source(
- MemorySourceConfig::try_new(&[input1.clone()], schema.clone(), None)
+ MemorySourceConfig::try_new(std::slice::from_ref(&input1),
schema.clone(), None)
Review Comment:
[A] slice fix (`&[input1.clone()]` --> `std::slice::from_ref(&input1)`)
##########
datafusion/core/tests/fuzz_cases/join_fuzz.rs:
##########
@@ -477,12 +477,18 @@ impl JoinFuzzTestCase {
fn left_right(&self) -> (Arc<DataSourceExec>, Arc<DataSourceExec>) {
let schema1 = self.input1[0].schema();
let schema2 = self.input2[0].schema();
- let left =
- MemorySourceConfig::try_new_exec(&[self.input1.clone()], schema1,
None)
- .unwrap();
- let right =
- MemorySourceConfig::try_new_exec(&[self.input2.clone()], schema2,
None)
- .unwrap();
+ let left = MemorySourceConfig::try_new_exec(
+ std::slice::from_ref(&self.input1),
+ schema1,
+ None,
+ )
+ .unwrap();
+ let right = MemorySourceConfig::try_new_exec(
+ std::slice::from_ref(&self.input2),
+ schema2,
+ None,
+ )
+ .unwrap();
Review Comment:
[A] slice fix (`&[self.input.clone()]` -->
`std::slice::from_ref(&self.input)`)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
