shruti2522 commented on code in PR #17100:
URL: https://github.com/apache/datafusion/pull/17100#discussion_r2267413326
##########
datafusion/datasource/src/statistics.rs:
##########
@@ -57,12 +57,12 @@ impl MinMaxStatistics {
/// Min value at index
#[allow(unused)]
- pub fn min(&self, idx: usize) -> Row {
+ pub fn min(&'_ self, idx: usize) -> Row<'_> {
self.min_by_sort_order.row(idx)
}
/// Max value at index
- pub fn max(&self, idx: usize) -> Row {
+ pub fn max(&'_ self, idx: usize) -> Row<'_> {
self.max_by_sort_order.row(idx)
}
Review Comment:
[C] lifetime added
##########
datafusion/expr/src/table_source.rs:
##########
@@ -121,7 +121,7 @@ pub trait TableSource: Sync + Send {
/// Get the Logical plan of this table provider, if available.
///
/// For example, a view may have a logical plan, but a CSV file does not.
- fn get_logical_plan(&self) -> Option<Cow<LogicalPlan>> {
+ fn get_logical_plan(&'_ self) -> Option<Cow<'_, LogicalPlan>> {
Review Comment:
[C] lifetime added
##########
datafusion/functions-aggregate/benches/array_agg.rs:
##########
@@ -45,7 +45,7 @@ fn merge_batch_bench(c: &mut Criterion, name: &str, values:
ArrayRef) {
black_box(
ArrayAggAccumulator::try_new(&list_item_data_type, false)
.unwrap()
- .merge_batch(&[values.clone()])
+ .merge_batch(std::slice::from_ref(&values))
Review Comment:
[A] slice fix (`&[values.clone()]` --> `std::slice::from_ref(&values)`)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
